Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use sdk.FileInfo in zbox list-all #377

Merged
merged 2 commits into from
Mar 7, 2023
Merged

use sdk.FileInfo in zbox list-all #377

merged 2 commits into from
Mar 7, 2023

Conversation

boddumanohar
Copy link
Contributor

@boddumanohar boddumanohar commented Mar 6, 2023 •
edited by cnlangzi
Loading

A brief description of the changes in this PR:

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@boddumanohar boddumanohar mentioned this pull request Mar 6, 2023
Merged
3 tasks
@boddumanohar boddumanohar requested a review from cnlangzi March 6, 2023 16:49
@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests master
gosdk fix-responses
zboxcli zbox-list-all
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@boddumanohar boddumanohar requested a review from dabasov March 6, 2023 18:53
dabasov
dabasov approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boddumanohar boddumanohar mentioned this pull request Mar 6, 2023
Closed
@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests zbox-list-all
gosdk staging
zboxcli zbox-list-all
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests master
gosdk staging
zboxcli zbox-list-all
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@boddumanohar boddumanohar merged commit fa6be0c into staging Mar 7, 2023
@boddumanohar boddumanohar deleted the zbox-list-all branch March 7, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabasov dabasov dabasov approved these changes

@cnlangzi cnlangzi Awaiting requested review from cnlangzi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boddumanohar @service-0chain @dabasov