-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rewrite ZeroEx in Yul #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good stuff, just a couple of nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One sugg, but looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This is a Yul rewrite of the
ZeroEx
contract. This saves about 1,000 gas as compared to the Solidity implementation.The function
getFunctionImplementation(bytes4)
has been moved out intoSimpleFunctionRegistryFeature
.Testing instructions
From
contracts/zero-ex
,yarn build && yarn test
.There are no new tests. No functionality should change from the previous implementation except the removal of
getFunctionImplementation(bytes4)
.Types of changes
Checklist:
[WIP]
if necessary.