Add checkAllowance flag to LibTokenSpender.spendERC20Tokens #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moodlezoup
requested review from
abandeali1,
dorothy-zbornak and
hysz
as code owners
moodlezoup
changed the title
moodlezoup
force-pushed
the
fix/plp_vip_check_allowance
branch
3 times, most recently
from
64fc05b to
33f6342
Compare
…check in LiquidityProviderFeature
moodlezoup
force-pushed
the
fix/plp_vip_check_allowance
branch
from
33f6342 to
a58665d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And make use of the new flag in LiquidityProviderFeature, TransformERC20Feature, and MetaTransactionsFeature
Description
Testing instructions
Types of changes
Checklist:
[WIP]if necessary.