require txOrigin for RFQ orders, allow origins to register alternate … #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarx
requested review from
abandeali1,
dorothy-zbornak,
hysz and
moodlezoup
as code owners
|
Question: what (if any) events do we need to add for registering and unregistering allowed origins? |
dorothy-zbornak
approved these changes
Nov 24, 2020
| @@ -862,8 +880,11 @@ contract NativeOrdersFeature is | |||
| ).rrevert(); | |||
| } | |||
|
|
|||
| LibNativeOrdersStorage.Storage storage stor = | |||
There was a problem hiding this comment.
Can we block scope this to free up the stack?
| @@ -86,10 +86,10 @@ blockchainTests.resets('NativeOrdersFeature', env => { | |||
| await makerToken.mint(maker, order.makerAmount).awaitTransactionSuccessAsync(); | |||
| if ('takerTokenFeeAmount' in order) { | |||
| await takerToken | |||
| .mint(taker, order.takerAmount.plus(order.takerTokenFeeAmount)) | |||
| .mint(_taker, order.takerAmount.plus(order.takerTokenFeeAmount)) | |||
| /// @param origin The address doing the registration. | ||
| /// @param addr The address being registered. | ||
| /// @param allowed Indicates whether the address should be allowed. | ||
| event OriginAllowed( |
There was a problem hiding this comment.
Let's make these names more verbose, like RfqOrderOriginAllowed
| /// specifies the message sender as its txOrigin. | ||
| /// @param origin The origin to update. | ||
| /// @param allowed True to register, false to unregister. | ||
| function registerAllowedOrigin(address origin, bool allowed) |
There was a problem hiding this comment.
Maybe
Suggested change
| function registerAllowedOrigin(address origin, bool allowed) | |
| function registerAllowedRfqOrigin(address origin, bool allowed) |
smarx
force-pushed
the
feat/origin-registry
branch
from
831a2ae to
737bd0e
Compare
hysz
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…addresses that can fill orders
Description
RFQ orders now require that the tx.origin is either txOrigin or another address that's been specifically allowed (via
registerAllowedOrigin()).Testing instructions
yarn testTypes of changes
Checklist:
[WIP]if necessary.