remove calldata signing #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarx
requested review from
abandeali1,
dorothy-zbornak,
hysz and
moodlezoup
as code owners
dorothy-zbornak
approved these changes
Nov 25, 2020
There was a problem hiding this comment.
Love a good code RIP.
This has implications on our next deployment though (cc @hysz @dekz). The next time we deploy MetaTransactions or TransformERC20 we will also need to redeploy ALL the transformers. We will also need to coordinate with API (and maybe Matcha) during this deployment to all switch over at the same time as soon as the governor TX is executed. Basically another hectic all-hands-on-deck thing 😢.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
remove calldata signing
Testing instructions
yarn testTypes of changes
Checklist:
[WIP]if necessary.