Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offboard Cream #546

Merged
merged 3 commits into from
Aug 10, 2022
Merged

Offboard Cream #546

merged 3 commits into from
Aug 10, 2022

Conversation

eobbad
Copy link
Contributor

@eobbad eobbad commented Aug 9, 2022

Description

Offboard cream

Types of changes

Offboarding

Checklist:

  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

@eobbad eobbad requested a review from kyu-c August 9, 2022 20:28
@eobbad eobbad marked this pull request as ready for review August 9, 2022 20:28
@eobbad eobbad requested review from dekz and dextracker as code owners August 9, 2022 20:28
@eobbad eobbad requested review from dextracker and removed request for dekz and dextracker August 9, 2022 20:29
kyu-c
kyu-c approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@kyu-c kyu-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!
LGTM -- just a minor timestamp thing in CHANGELOG.json

(Likely CHANGELOG.json will need to be updated again after rebasing it)

packages/asset-swapper/CHANGELOG.json Outdated Show resolved Hide resolved
@eobbad eobbad force-pushed the chore/offboard/cream branch 2 times, most recently from 45260fd to 3877409 Compare August 10, 2022 01:12
@eobbad eobbad force-pushed the chore/offboard/cream branch from 3877409 to 39c0b38 Compare August 10, 2022 12:32
@eobbad eobbad merged commit b35dccd into development Aug 10, 2022
@eobbad eobbad deleted the chore/offboard/cream branch August 10, 2022 12:42
@kyu-c kyu-c mentioned this pull request Sep 1, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyu-c kyu-c kyu-c approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eobbad @kyu-c