Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[protocol-utils] tslint->eslint #582

Merged
merged 7 commits into from
Sep 21, 2022
Merged

[protocol-utils] tslint->eslint #582

merged 7 commits into from
Sep 21, 2022

Conversation

eobbad
Copy link
Contributor

@eobbad eobbad commented Sep 21, 2022 •
edited
Loading

Description

Testing instructions

Types of changes

Checklist:

  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

@eobbad eobbad marked this pull request as ready for review September 21, 2022 23:26
@eobbad eobbad requested a review from dekz as a code owner September 21, 2022 23:26
@eobbad eobbad requested a review from kyu-c September 21, 2022 23:26
kyu-c
kyu-c reviewed Sep 21, 2022
View reviewed changes
packages/protocol-utils/package.json Outdated Show resolved Hide resolved
packages/protocol-utils/package.json Outdated Show resolved Hide resolved
@eobbad eobbad requested a review from kyu-c September 21, 2022 23:31
kyu-c
kyu-c approved these changes Sep 21, 2022
View reviewed changes
Copy link
Collaborator

@kyu-c kyu-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/protocol-utils/CHANGELOG.json Outdated Show resolved Hide resolved
@eobbad eobbad merged commit b4d6f74 into development Sep 21, 2022
@eobbad eobbad deleted the chore/eslint2 branch September 21, 2022 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyu-c kyu-c kyu-c approved these changes

@dekz dekz Awaiting requested review from dekz dekz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eobbad @kyu-c