Return unoptimized quote in SwapQuote #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xianny
requested review from
dekz and
dorothy-zbornak
and removed request for
BMillman19 and
dave4506
xianny
commented
Dec 1, 2020
| * on a single quote info instead of using best and worst case | ||
| * Orders must be derived from the same path as the quote info | ||
| */ | ||
| export function getQuoteInfoMinBuyAmount( |
There was a problem hiding this comment.
I use this in 0x-api to calculate affiliate fees if any
xianny
commented
Dec 1, 2020
| makerTokenDecimals, | ||
| takerTokenDecimals, | ||
| }; | ||
| } |
There was a problem hiding this comment.
Did a little refactoring but functionality should be the same
xianny
commented
Dec 1, 2020
Comment on lines
+181
to
+189
| // Calculate the unoptimised alternative | ||
| const unoptimizedFillResult = simulateBestCaseFill({ | ||
| gasPrice, | ||
| orders: optimizedOrders, | ||
| orders: unoptimizedPath.orders, | ||
| side: operation, | ||
| fillAmount: assetFillAmount, | ||
| opts: { gasSchedule }, | ||
| }); | ||
| const unoptimizedQuoteInfo = fillResultsToQuoteInfo(unoptimizedFillResult); |
There was a problem hiding this comment.
This is new, the rest is refactoring
xianny
commented
Dec 1, 2020
| bestCaseQuoteInfo, | ||
| worstCaseQuoteInfo, | ||
| unoptimizedQuoteInfo, | ||
| unoptimizedOrders: unoptimizedPath.orders, |
There was a problem hiding this comment.
This line is new too, the rest is refactoring
dorothy-zbornak
approved these changes
Dec 1, 2020
Comment on lines
22
to
24
| const paths = fills.map(singleSourceFills => Path.create(side, singleSourceFills, targetInput, opts)); | ||
| // Sort fill arrays by descending adjusted completed rate. | ||
| const sortedPaths = paths.sort((a, b) => b.adjustedCompleteRate().comparedTo(a.adjustedCompleteRate())); |
There was a problem hiding this comment.
This code is duped below. Can we refactor to avoid the dupe? Maybe add a fillsToPathsSortedByAdjustedCompletedRate()?
|
Ya, it looks like this in API: 0xProject/0x-api#435 (comment) Pretty unambiguous! |
xianny
force-pushed
the
feat/return-unoptimized-amounts
branch
from
aa12232 to
5bc0457
Compare
xianny
added a commit
that referenced
this pull request
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supports new feature: calculating user savings.
Blocks: 0xProject/0x-api#435
This PR adds new fields
unoptimizedQuoteInfoandunoptimizedOrdersto the SwapQuote.These new fields represent the best rate available from a single source, which would be the best alternative to our multi-source optimized path.
Testing instructions
Types of changes
Checklist:
[WIP]if necessary.