Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a repeat function for the player memorizing Quran #78

Closed
zayedalsaidi opened this issue Jun 1, 2024 · 8 comments · Fixed by #84
Closed

Add a repeat function for the player memorizing Quran #78

zayedalsaidi opened this issue Jun 1, 2024 · 8 comments · Fixed by #84
Assignees
Labels
enhancement New feature or request

Comments

@zayedalsaidi
Copy link

The feature request

Please add a repeat function for the player (for a range of Ayats) similar to this:
https://www.nquran.com/ar/quranplayer/

Proposed solution

https://www.nquran.com/ar/quranplayer/

Additional context

No response

@0xzer0x 0xzer0x added the enhancement New feature or request label Jun 1, 2024
@0xzer0x 0xzer0x moved this to Todo in Quran Companion Jun 1, 2024
@0xzer0x 0xzer0x self-assigned this Jun 1, 2024
@0xzer0x 0xzer0x moved this from Todo to In Progress in Quran Companion Jun 15, 2024
@0xzer0x 0xzer0x mentioned this issue Jun 22, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Quran Companion Jun 22, 2024
@zayedalsaidi
Copy link
Author

@0xzer0x thank you for your effort. Today, I have chance to check the version 1.2.7 on Linux (Flatpak). Unfortunately, the repeat button does not work. Do I miss something here?

@0xzer0x
Copy link
Owner

0xzer0x commented Jun 24, 2024

Just tested the Flatpak version and seems to be working fine. Maybe try the AppImage and check if the issue persists?

@zayedalsaidi
Copy link
Author

Still same issue.

image

@zayedalsaidi
Copy link
Author

zayedalsaidi commented Jun 25, 2024 via email

@0xzer0x
Copy link
Owner

0xzer0x commented Jun 25, 2024

Probably an issue with the popup widget positioning on screen. The positioning seems to have inconsistent behavior on Windows and maybe this is a similar issue. Will look into it.

@0xzer0x
Copy link
Owner

0xzer0x commented Jun 25, 2024

Apparently it is due to positioning the repeater widget using screen coordinates not the parent widget coordinate system. Should be fixed in 434cbf8

@0xzer0x
Copy link
Owner

0xzer0x commented Jun 25, 2024

Please give v1.2.8 AppImage a try and let me know if the issue is still present.

@zayedalsaidi
Copy link
Author

It's working flawlessly under Linux. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants