Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip Links Example 404's #338

Closed
darylldoyle opened this issue Sep 15, 2020 · 0 comments · Fixed by #343
Closed

Skip Links Example 404's #338

darylldoyle opened this issue Sep 15, 2020 · 0 comments · Fixed by #343
Assignees
Labels

Comments

@darylldoyle
Copy link
Contributor

Describe the bug
The best practices reference the Underscores theme when talking about skip links. Unfortunately, it seems that since Underscores have dropped support for IE11 they've also removed the skip-link-focus-fix.js file that is referenced (Automattic/_s#1424).

I'd suggest that either the link is updated to point to the last commit before its removal (available here), that it's moved to somewhere 10up has control of (Github Gist, inline in the skip link section etc.) or that another good example is found and linked to.

Steps to Reproduce

  1. Go to https://10up.github.io/Engineering-Best-Practices/markup/#accessibility
  2. Scroll down to "Skip Links" section
  3. Click on the link within the "The popular Underscores starter theme comes bundled with a good option that can be used as a starting point." content.
  4. See 404
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant