Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the skip link focus fix #1424

Merged
merged 1 commit into from
May 7, 2020
Merged

Remove the skip link focus fix #1424

merged 1 commit into from
May 7, 2020

Conversation

Ismail-elkorchi
Copy link
Contributor

Changes proposed in this Pull Request:

This fix is only necessary for IE11. Now that we are dropping support for IE11, we can safely remove the skip link focus fix.

Related issue(s):

#1421
#1206
closes #1323

@Ismail-elkorchi Ismail-elkorchi merged commit 301248d into Automattic:master May 7, 2020
@Ismail-elkorchi Ismail-elkorchi deleted the remove-skip-link-fix branch May 7, 2020 05:09
dsgreen added a commit to dsgreen/_s that referenced this pull request Sep 9, 2020
* 'master' of https://github.com/Automattic/_s: (92 commits)
  Remove PHPCS Ignore Around $content-width (Automattic#1450)
  Use _S_VERSION constant when enqueuing customizer.js (Automattic#1445)
  Update composer and node dependencies (Automattic#1444)
  Add missing s in languages directory name (Automattic#1442)
  Exclude alignment classes from RTL conversion (Automattic#1435)
  Add new required header fields for style.css (Automattic#1432)
  Remove redundant font-size declarations (Automattic#1434)
  Refactor navigation.js to Javascript ES6 (Automattic#1423)
  Delete the custom bundle script in favor of an npm package (Automattic#1433)
  Fix small typo (Automattic#1428)
  Re-organize SASS structure (Automattic#1425)
  Add a SASS watcher command (Automattic#1427)
  Remove the skip link focus fix (Automattic#1424)
  Replace className.indexOf with classList.contains (Automattic#1422)
  Use CSS grid for gallery styles (Automattic#1246)
  Update README.md documentation (Automattic#1419)
  Add a bundle script to generate a zip file for theme distribution (Automattic#1417)
  Update npm dependencies (Automattic#1418)
  Float implies the use of the block layout (Automattic#960)
  Use the system font stack from WP admin (Automattic#1416)
  ...
krafit added a commit to krafit/autonomie that referenced this pull request Mar 31, 2024
As this fix is only necessary for IE11, it should no longer be necessary in 2024.

_s removed this file in 2020 (Automattic/_s#1424)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant