Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added OWNERDOMAIN & MANAGERDOMAIN #108

Merged
merged 2 commits into from
Oct 26, 2022
Merged

Added OWNERDOMAIN & MANAGERDOMAIN #108

merged 2 commits into from
Oct 26, 2022

Conversation

SoftCreatR
Copy link
Contributor

@SoftCreatR SoftCreatR commented Oct 24, 2022

Resolves #107

Changelog Entry

Added - Support for OWNERDOMAIN & MANAGERDOMAIN per version 1.1 of the spec.

Credits

Props @SoftCreatR, @tott.

@jeffpaul jeffpaul added this to the 1.5.0 milestone Oct 25, 2022
@jeffpaul
Copy link
Member

@SoftCreatR welcome to Ads.txt Manager and thanks for the PR. I've passed this along to our team to review and will get back to you with any concerns... cheers!

Copy link
Contributor

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and works using the test code from the spec.

I've added a suggestion inline to update the comment above the change. I'll self merge that so we can merge the pull request.

Thanks for your help maintaining ads.txt!

inc/save.php Outdated Show resolved Hide resolved
@SoftCreatR
Copy link
Contributor Author

Dang, I've missed that :)

@peterwilsoncc
Copy link
Contributor

It's easily done :)

I've approved the PR but noticed the repo's settings need to be updated before I can merge. Once that happens in the next few days, I'll merge.

@jeffpaul jeffpaul merged commit 3be2e20 into 10up:develop Oct 26, 2022
@peterwilsoncc peterwilsoncc modified the milestones: 1.5.0, 1.4.1 Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing variables OWNERDOMAIN and MANAGERDOMAIN
3 participants