Add a notice to the edit screen if ads.txt already exists on the server

[kkoppenhaver]

Addresses #16

When the presence of an existing ads.txt is detected, display a notification on the edit screen.

[helen]

Hi! Thanks for the PR. A couple of notes from a first look:

• All UI text needs to be run through (preferably escaped) translation functions, e.g. esc_html_e().
• All-caps are less readable and should be done in CSS if absolutely necessary.
• I'm not sure a file_exists() check on every load is a great idea for performance, or that $_SERVER['DOCUMENT_ROOT'] is guaranteed to be accurate. I don't currently have alternate suggestions, but something to think about :)

[kkoppenhaver]

Re: the admin notice, those are good ideas. Cleaned it up a bit with that latest commit as well as added the translation and escaping:

As far as your third point, how do you feel about using something like wp_remote_get (or vip_safe_wp_remote_get) to get the data at http://exampleurl.com/adx.txt and comparing it to what the plugin expects the output to be? If the output matches, then ads.txt is being served from the plugin. If it doesn't, then there's likely a file already in place.

This call could be cached using transients to reduce the load on the server and would be accompanied by a Check Again link or something similar in the admin notice to re-perform this check if the user believes the file has been removed.

[tomjn]

As far as your third point, how do you feel about using something like wp_remote_get (or vip_safe_wp_remote_get) to get the data at http://exampleurl.com/adx.txt and comparing it to what the plugin expects the output to be? If the output matches, then ads.txt is being served from the plugin. If it doesn't, then there's likely a file already in place.

In the case of VIP, you would be better checking for a VIP environment and if found, bypassing the check, as it wouldn't make a lot of sense to do in a VIP context

As for wp_remote_get, that sounds like something that would be more peformant as a JS based check

[kkoppenhaver]

My only thought now that the check is in JS is whether we should attempt to cache the result in a cookie for some amount of time so it's not performing the JS check on every load of the ads.txt admin page.

@tomjn

[tomjn]

It would only be doing the check on that page, so it's up to you

[kkoppenhaver]

Alright then I think this is ready for another review. Not sure if that's @helen or who should be looking at that. Happy to make any further changes.

[tomjn]

I've no further opinions on the matter

[adamsilverstein]

requested some changes

[adamsilverstein]

Hey @kkoppenhaver - thank you for your contribution, this seems like a great user experience improvement for admins who may not realize the already have the ads.txt file.

I left some feedback on the PR (sorry for the long delay in getting back to you). Do you think you will have time to work on addressing my feedback sometime soon, or would like some assistance getting this over the finish line?

[kkoppenhaver]

@adamsilverstein Thanks for the feedback. I should be able to take a look early next week.

[kkoppenhaver]

@adamsilverstein I think that should take care of everything you've raised. I've run it through testing of various scenarios locally and the check is performing as expected.

[adamsilverstein]

@kkoppenhaver This works great, thanks for keeping at it! I left a few small code suggestions and I would like to have @helen review the copy here, otherwise this is ready to go!

[adamsilverstein]

Current screenshot:

[adamsilverstein]

Fantastic.

[helen]

Marking as needs changes but from me, just tweaking the notice language.

[helen]

I would like for this to say something about why there's a difference between an actual file and what this plugin is doing, because I don't think that's very clear to most people. I'll think on exact language.

[adamsilverstein]

How about something like:

We detected a hard coded ads.txt file on your site. This file takes precedence over the plugin, preventing it from working correctly. Please remove this file to use Ads-txt.

[helen]

I added a spinner for visual feedback and massaged the messaging and I think we're good to go for this release. We will probably want to rethink the actual detection approach here (again) at some point given #26 or maybe use a specific query arg name that we detect but I don't want to let this languish forever :)