Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes early escaping #25

Merged
merged 1 commit into from
Apr 20, 2018
Merged

Fixes early escaping #25

merged 1 commit into from
Apr 20, 2018

Conversation

tomjn
Copy link
Contributor

@tomjn tomjn commented Apr 17, 2018

  • Renames the format_error function so it's clear that it outputs internally
  • Uses wp_kses_post as it allows code tags through on the $message object
  • Makes the function output internally

@tomjn
Fixes early escaping
497c5dc 
- Renames the `format_error` function so it's clear that it outputs internally
- Uses `wp_kses_post` as it allows code tags through on the `$message` object
- Makes the function output internally
@helen
Copy link
Contributor

helen commented Apr 20, 2018

Makes sense to me! Just for future me (or whoever), I believe format_error() was a non-outputting function because it used to save a fully formatted message to meta, which was... not good :)

@helen helen merged commit 26e30a1 into 10up:develop Apr 20, 2018
@helen helen added this to the 1.2 milestone Apr 20, 2018
@jeffpaul jeffpaul requested a review from helen June 17, 2019 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helen helen Awaiting requested review from helen

Assignees

@tomjn tomjn

Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tomjn @helen