Add INVENTORYPARTNERDOMAIN as a supported variable
#74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffpaul
requested review from
a team and
faisal-alvi
and removed request for
a team
faisal-alvi
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
In v1.0.3 of the ads.txt spec, a new variable called
INVENTORYPARTNERDOMAINwas added. This PR adds that to our list of supported variables so you don't get a warning when saving.Alternate Designs
None
Benefits
You won't get a warning on a valid variable
Possible Drawbacks
None
Verification Process
Create a ads.txt file with the following line:
inventorypartnerdomain=test.comEnsure it saves properly with no errors and shows up properly in the actual ads.txt file
Checklist:
Applicable Issues
#72
Changelog Entry