Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize copy and links for editor notification on linked remote posts #611

Closed
3 tasks
jeffpaul opened this issue Jul 9, 2020 · 2 comments
Closed
3 tasks
Assignees
Labels
help wanted type:enhancement New feature or request. type:good-first-issue Good for newcomers.
Milestone

Comments

@jeffpaul
Copy link
Member

jeffpaul commented Jul 9, 2020

Is your enhancement related to a problem? Please describe.
Depending on whether you push or pull a post and whether you view the remote post in Gutenberg or the Classic Editor, you will get four different possible editor notifications that the remote post is linked to the origin post. Let's try and standardize the copy and format of what's displayed.

Pulled post in Gutenberg:
Screen Shot 2020-07-08 at 8 04 29 PM

Pulled post in Classic Editor:
Screen Shot 2020-07-08 at 8 05 30 PM

Pushed post in Gutenberg:
Screen Shot 2020-07-08 at 8 06 16 PM

Pushed post in Classic Editor:
Screen Shot 2020-07-08 at 8 07 10 PM

Describe the solution you'd like

  • standardize copy to "Distributed from origin site name. The original will update this version unless you unlink from the original."
  • link the text for origin site name to the origin post
  • link "unlink from the original" to the Distributor unlink action

Designs

n/a

Describe alternatives you've considered

None, we should be standardizing this copy, links, and action across all possible permutations of the editor notification.

Additional context

n/a

@jeffpaul jeffpaul added type:enhancement New feature or request. help wanted type:good-first-issue Good for newcomers. labels Jul 9, 2020
@jeffpaul jeffpaul added this to the 1.7.0 milestone Jul 9, 2020
@jeffpaul jeffpaul modified the milestones: 1.7.0, 1.6.3 Jan 15, 2021
@cdwieber
Copy link

After toying with this a bit, I can see why the Gutenberg version is set up as it is: the notification accepts simply a "message" and then an array of "actions", so the "message" must necessarily be separated from the "actions" (i.e. unlink, view original).* It seems that the i18n functions escape HTML making kludging in an inline link difficult without upending the notification system. There may be a way to do it I'm not seeing, but from now I'll submit a PR that takes care of the verbiage discrepancy and go from there.

*Reference: assets/js/gutenberg-syndicated-post.js:14

@jeffpaul
Copy link
Member Author

jeffpaul commented Feb 2, 2021

@cdwieber do you think there's more we can technically do to standardize that copy or do you think what we've got merged in your PR is the best we can do and should otherwise close this issue?

@jeffpaul jeffpaul closed this as completed Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted type:enhancement New feature or request. type:good-first-issue Good for newcomers.
Projects
None yet
Development

No branches or pull requests

2 participants