Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize Distributed Alert Copy #696

Merged
merged 2 commits into from
Jan 27, 2021

Conversation

cdwieber
Copy link

@cdwieber cdwieber commented Jan 18, 2021

Partially addresses #611

Description of the Change

Per #611, the notification copy between the classic and Gutenberg editors was inconsistent. This PR simply updates said verbiage for consistency between Gutenberg and Classic.

Alternate Designs

The original spec called for an inline link to the original post as opposed to the "View Original" action in the Gutenberg notification. As outlined in a comment in #611, the notification architecture might have to be altered to account for this, so this PR will only address the verbiage.

Benefits

Verbiage for the notifications will be more consistent across editors.

Possible Drawbacks

None.

Verification Process

  1. Visit a distributed post in the Gutenberg editor, and ensure that the verbiage matches that of the Classic editor.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change. | WPAcceptance test changed accordingly.
  • All new and existing tests passed.

Applicable Issues

The inline link still needs to be added to the Gutenberg notification so as to match the Classic

Changelog Entry

Changed some notification text for added consistency.

@jeffpaul jeffpaul added this to the 1.6.3 milestone Jan 18, 2021
@jeffpaul jeffpaul requested a review from dkotter January 18, 2021 21:24
@jeffpaul jeffpaul merged commit b6e10ee into develop Jan 27, 2021
@jeffpaul jeffpaul deleted the fix/611-standardize-distributed-alert-copy branch January 27, 2021 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants