-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Application Passwords handling for WordPress 5.6 #661
Comments
I'm just a new user of this plugin, but isn't this issue urgent by now? WP 5.6 is scheduled to be released in a few days. Will everything continue to work on Wordpress 5.6? Won't the plugin at least need a check to see if the Application Password class already exists (from native WP) and use that if it does? Also, the settings screen of the plugin still recommends installing Application Passwords as a separate plugin, while it's actually provided with Distributor. Trying to activate the separate plugin of course throws a fatal error because the class is already defined. This is out of date and should no longer be recommended. This point could be fixed together with any changes surrounding Application Passwords needed for WP 5.6. |
As @geertvdheide1 notes, we'll likely want to update our docs at https://github.com/10up/distributor#setup-external-connections-using-application-passwords to reference this will only be necessary on WP versions before 5.6 as from 5.6 onwards Application Passwords will come bundled with WP core. |
Noting that when trying to use the |
Noting that I still need to test Pulling content and creating a new External Connection. |
Auth Wizard is not working with Application Password in core. A fix is in progress. |
Is your enhancement related to a problem? Please describe.
When WordPress 5.6 is released, currently scheduled for 8 December 2020, we will want to handle for the scenario where Application Passwords is now available in WordPress core as it was merged as part of the 5.6 Beta 1 release.
Describe the solution you'd like
This issue will help us track discussion on how best to handle for this scenario
Designs
Describe alternatives you've considered
n/a
Additional context
n/a
The text was updated successfully, but these errors were encountered: