Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Application Passwords handling for WordPress 5.6 #661

Closed
jeffpaul opened this issue Oct 28, 2020 · 7 comments · Fixed by #676 or #681
Closed

Update Application Passwords handling for WordPress 5.6 #661

jeffpaul opened this issue Oct 28, 2020 · 7 comments · Fixed by #676 or #681
Assignees
Labels
help wanted needs:discussion This requires discussion to determine next steps. needs:tests This requires tests. type:enhancement New feature or request.
Milestone

Comments

@jeffpaul
Copy link
Member

Is your enhancement related to a problem? Please describe.
When WordPress 5.6 is released, currently scheduled for 8 December 2020, we will want to handle for the scenario where Application Passwords is now available in WordPress core as it was merged as part of the 5.6 Beta 1 release.

Describe the solution you'd like
This issue will help us track discussion on how best to handle for this scenario

Designs

Describe alternatives you've considered
n/a

Additional context
n/a

@jeffpaul jeffpaul added type:enhancement New feature or request. needs:tests This requires tests. needs:discussion This requires discussion to determine next steps. plugins labels Oct 28, 2020
@jeffpaul jeffpaul added this to the 1.7.0 milestone Oct 28, 2020
@jeffpaul
Copy link
Member Author

jeffpaul commented Nov 5, 2020

@geertvdheide1
Copy link

I'm just a new user of this plugin, but isn't this issue urgent by now? WP 5.6 is scheduled to be released in a few days. Will everything continue to work on Wordpress 5.6? Won't the plugin at least need a check to see if the Application Password class already exists (from native WP) and use that if it does?

Also, the settings screen of the plugin still recommends installing Application Passwords as a separate plugin, while it's actually provided with Distributor. Trying to activate the separate plugin of course throws a fatal error because the class is already defined. This is out of date and should no longer be recommended. This point could be fixed together with any changes surrounding Application Passwords needed for WP 5.6.

@jeffpaul
Copy link
Member Author

jeffpaul commented Dec 7, 2020

Just tested on a new WP 5.6 RC4 install, installed and activated Distributor 1.6.1, and the User Profile now presents two Application Passwords sections:
Screen Shot 2020-12-06 at 9 33 31 PM

On a network install, with a preexisting External Connection, it similarly duplicates the Application Passwords section in the User Profile and also duplicates the reference to the external connection:
Screen Shot 2020-12-06 at 22 00 24-fullpage

The network site was able to still distribute to internal and external connections, the remote site was able to distribute back to the origin site in the network as well. So all Distributor functionality appears to work as expected, though there's definitely a case where some confusion will arise from the duplicate Application Passwords sections in the User Profile.

@jeffpaul
Copy link
Member Author

jeffpaul commented Dec 7, 2020

As @geertvdheide1 notes, we'll likely want to update our docs at https://github.com/10up/distributor#setup-external-connections-using-application-passwords to reference this will only be necessary on WP versions before 5.6 as from 5.6 onwards Application Passwords will come bundled with WP core.

@jeffpaul
Copy link
Member Author

jeffpaul commented Dec 7, 2020

Noting that when trying to use the Application Passwords section Revoke button, that only the first section works to actually revoke while the second instance of the section does nothing upon clicking the Revoke button.

@jeffpaul jeffpaul modified the milestones: 1.7.0, 1.6.2 Dec 7, 2020
@jeffpaul
Copy link
Member Author

jeffpaul commented Dec 8, 2020

Noting that I still need to test Pulling content and creating a new External Connection.

@dinhtungdu
Copy link
Contributor

Auth Wizard is not working with Application Password in core. A fix is in progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted needs:discussion This requires discussion to determine next steps. needs:tests This requires tests. type:enhancement New feature or request.
Projects
None yet
3 participants