Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Application Passwords handling for WordPress 5.6 #676

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Conversation

dinhtungdu
Copy link
Contributor

Description of the Change

With Application Password in core since 5.6, the Application Passwords section on the user profile edit page now is duplicated. This PR fixes that issue by loading only one Application Password class. The class can be one of three sources: WordPress core, Application Password Plugin, and the plugin bundled with Distributor.

Verification Process

  • Update the site to 5.6.
  • Go to user profile edit page.
  • See only one Application password section.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Fixes #661

Changelog Entry

@dinhtungdu dinhtungdu added this to the 1.6.2 milestone Dec 9, 2020
@dinhtungdu dinhtungdu self-assigned this Dec 9, 2020
@jeffpaul jeffpaul requested a review from dkotter December 9, 2020 16:24
@jeffpaul jeffpaul merged commit 1d5dd57 into develop Dec 9, 2020
@jeffpaul jeffpaul deleted the fix/661 branch December 9, 2020 17:46
@dkotter dkotter mentioned this pull request Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Application Passwords handling for WordPress 5.6
3 participants