Test against WordPress 5.7

[jeffpaul]

Is your enhancement related to a problem? Please describe.
Once WordPress 5.7 is released, we'll want to test Distributor to see if any incompatibility issues arise.

Describe the solution you'd like

• test Distributor on WordPress 5.7
• open issues for any incompatibilities noted in testing
• resolve issues identified in testing
• bump "tested up to" version
• if code changes needed due to incompatibilities, ship a plugin release

Designs
n/a

Describe alternatives you've considered
none

Additional context
Related: #568, #624.

[antoinebougr]

Hi

I m facing a fatal error after wordpress 5.7 update. For the moment I disabled distributor to make wordpress work again

[dkotter]

@antoinebougr Thanks for the report. This doesn't seem to be related to the latest WordPress update but does seem like this may be related to the latest Distributor release. I have not been able to reproduce this error on either WP 5.6 or 5.7, with the latest release of Distributor. Can you let me know what version of PHP you are using? Based on the error you shared, seems like it may be a compatibility issue with a certain version of PHP.

[PaddyWhacks]

Just updated Multisite to WordPress 5.7 and distributor to 1.6.3. Rolling back to 1.6.2 works. Same error message as @antoinebougr -

Fatal error: Declaration of Distributor\ExternalConnection::log_sync() must be compatible with Distributor\Connection::log_sync(array $item_id_mappings, $id, Distributor\bool $overwrite) in /home/dotnewsb/public_html/wp-content/plugins/distributor/includes/classes/ExternalConnection.php on line 17

There has been a critical error on this website. Please check your site admin email inbox for instructions.

Learn more about troubleshooting WordPress.

[dkotter]

@PaddyWhacks Do you happen to know what version of PHP you're site is running? Thanks!

[dkotter]

@PaddyWhacks @antoinebougr Just tested on various PHP versions and found the issue. With the latest release of Distributor and a site running PHP <7.2 (so 7.1, 7.0 or 5.6) a fatal error occurs. I just fixed this in PR #742, if you want to test that out.

[PaddyWhacks]

Thanks - All sorted now! :)