Fix a PHP fatal error with the log_sync
function
#742
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
In the latest Distributor release, we added an optional parameter to the
log_sync
method that is used to overwrite the log. The base method we extended had a type declaration on that optional value tobool
but the two places we extended this method didn't have that same type declaration. In PHP versions 7.0 and 7.1, this will cause a fatal error to be thrown because those function signatures don't match.In addition, PHP 5.6 does not support scalar type declarations, which
bool
is considered a scalar type. Because we still support PHP 5.6, this PR removes thebool
type declaration so no errors will happen in 5.6, 7.0 or 7.1.Alternate Designs
None
Benefits
No PHP fatals on PHP version <7.2
Possible Drawbacks
None
Verification Process
Checklist:
Applicable Issues
Fixes #734. Related #735