Add snippet for setting meta data automatically. #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterwilsoncc
force-pushed
the
do/971-custom-meta-snippet
branch
from
7aa2c98 to
5e6a6af
Compare
peterwilsoncc
commented
May 31, 2023
| @@ -428,7 +428,7 @@ public function pull( $items ) { | |||
| update_post_meta( $new_post, 'dt_full_connection', true ); | |||
| } | |||
|
|
|||
| if ( ! empty( $post_array['meta'] ) ) { | |||
| if ( isset( $post_array['meta'] ) && is_array( $post_array['meta'] ) ) { | |||
There was a problem hiding this comment.
The empty check was preventing the hook from running if there was no meta because empty( [] ) === true. My understanding is that the hook should fire regardless of whether there is or is not meta so I've changed it to fire when the array is set.
peterwilsoncc
force-pushed
the
do/971-custom-meta-snippet
branch
from
93759bf to
f8105f8
Compare
iamdharmesh
approved these changes
Jun 2, 2023
There was a problem hiding this comment.
Thanks for adding this @peterwilsoncc. Snippets working fine. LGTM 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Provides snippet for setting both Distributor and custom meta data using the
dt_after_set_metahook.Closes #971
How to test the Change
Changelog Entry
Credits
Props @peterwilsoncc, @iamdharmesh.
Checklist: