Continue migrating E2E tests to Cypress. #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterwilsoncc
changed the title
peterwilsoncc
force-pushed
the
do/1038-cypress-migration
branch
from
eaa9e8a to
cc2964f
Compare
peterwilsoncc
force-pushed
the
do/1038-cypress-migration
branch
from
f138e78 to
8ca7479
Compare
peterwilsoncc
force-pushed
the
do/1038-cypress-migration
branch
from
9153f1d to
b0c83a2
Compare
peterwilsoncc
commented
Jun 9, 2023
| @@ -17,6 +17,7 @@ body.dt-linked-post { | |||
| cursor: default; | |||
| } | |||
|
|
|||
| .edit-post-welcome-guide, | |||
There was a problem hiding this comment.
This change is to allow cy.closeWelcomeGuide(); to run by re-enabling pointer events on the modal. Without them, Cypress declines to click on the element because it's unclickable.
iamdharmesh
approved these changes
Jun 14, 2023
There was a problem hiding this comment.
Thanks a lot for the great work and efforts here @peterwilsoncc. LGTM!! 🚀
Comment on lines
+60
to
+62
| // This test is temporarily disabled due to failures in GitHub actions that are not reproducible locally. | ||
| // On GitHub the success message expected within the cy.distributorPushPost command is not found as the | ||
| // distribution fails with an undefined error. |
There was a problem hiding this comment.
Should we open an issue for this to tackle in the future?
There was a problem hiding this comment.
I've logged #1076 for follow up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Continue with migration of E2E tests from WPA to Cypress.
Closes #1038
How to test the Change
Changelog Entry
Credits
Props @peterwilsoncc
Checklist: