Fix cypress tests

[kirtangajjar]

Description of the Change

Fixes E2E tests

Closes #1241

How to test the Change

Changelog Entry

Fixed - E2E tests

Credits

Props @kirtangajjar

Checklist:

• I agree to follow this project's Code of Conduct.
• I have updated the documentation accordingly.
• I have added tests to cover my change.
• All new and existing tests pass.

[kirtangajjar]

The pending work here is described in #1237 (comment). Basically as we have removed quotes around command here, we need to do the same in https://github.com/10up/cypress-wp-utils/blob/develop/src/commands/wp-cli.ts#L21 unless we find a different solution.

[iamdharmesh]

@kirtangajjar PR looks good to me just added one note to discuss it.

we need to do the same in https://github.com/10up/cypress-wp-utils/blob/develop/src/commands/wp-cli.ts#L21 unless we find a different solution.

I have already raised PR 10up/cypress-wp-utils#128 to handle this in https://github.com/10up/cypress-wp-utils/

Just curious on why E2E test GH action check is not triggered on this PR 🤔

Thank you.

[jeffpaul]

@iamdharmesh looks like e2e tests are running with latest commit 🤷🏼

[kirtangajjar]

@jeffpaul I think the code is good to merge. I'm observing some tests are failing for Should push oEmbed content on some envs, which I think is because the tests might be flakey. I cannot think of other reasons why they're failing.

cc @iamdharmesh any thoughts on why the tests could be failing otherwise?

[iamdharmesh]

Yes @kirtangajjar, It seems like flaky tests. I tried re-run on my commit and now it is passing. Approving. Thanks for all your great work here.