Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/warning: Undefined array key "id" #1247

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Conversation

Sidsector9
Copy link
Member

@Sidsector9 Sidsector9 commented Jul 14, 2024

Description of the Change

This PR fixes a PHP warning shown on the "Pull Content" page.

How to test the Change

  1. Create 2 multisites env of types subdomain and subdir.

  2. Create pages and posts in both sites.

  3. Add the subdir site as external connection to subdomain site.

  4. Visit "Pull Content" and observe the error on develop.
    Screenshot 2024-07-15 at 12 35 56 AM

  5. Switch to the fix branch and see the error is fixed.

Changelog Entry

Fixed - Undefined array key "id" warning on the Pull Content page.

Credits

Props @Sidsector9

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@Sidsector9 Sidsector9 requested a review from peterwilsoncc July 14, 2024 19:10
@Sidsector9 Sidsector9 requested a review from a team as a code owner July 14, 2024 19:10
@Sidsector9 Sidsector9 self-assigned this Jul 14, 2024
@github-actions github-actions bot added this to the 2.1.0 milestone Jul 14, 2024
@github-actions github-actions bot added the needs:feedback This requires reporter feedback to better understand the request. label Jul 14, 2024
Copy link

@Sidsector9 thanks for the PR! Could you please fill out the PR template with description, changelog, and credits information so that we can properly review and merge this?

@github-actions github-actions bot added needs:code-review This requires code review. and removed needs:feedback This requires reporter feedback to better understand the request. labels Jul 14, 2024
Copy link
Collaborator

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can reproduce warning on develop and fix on this branch

@peterwilsoncc peterwilsoncc merged commit 3a45cb9 into develop Jul 22, 2024
14 of 20 checks passed
@peterwilsoncc peterwilsoncc deleted the fix/warning-array-id branch July 22, 2024 02:20
@dkotter dkotter modified the milestones: 2.1.0, 2.0.5 Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants