-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/1144 webp support #1269
base: develop
Are you sure you want to change the base?
Fix/1144 webp support #1269
Conversation
Before this PR is merged, we should:
|
Yes, tests can be added by mocking the image names. As the tests use https://github.com/10up/wp_mock/ the files don't need to exist in the repo. This should work for the fictional file type too.
As some of the supported media types depend on the version of underlying libraries installed (GD, ImageMagick) then I think it would be good for the pushing instance to know what the receiving instance supports. There's a few REST API endpoints that Distributor registers that the system could make use of. I think we'd only want to make the data available if the user is logged in to the endpoint but we'd need to check for the data during a push, which I don't think is something that's done at the moment. Maybe add the data to |
Flagging that I'm not sure when I'm going to have time to work on this PR again. |
Description of the Change
This PR:
Closes #810
How to test the Change
Upload test AVIF, HEIC, and WebP files to a Distributor source site. Ensure taht they are synchronized to a downstream Distributor site.
Changelog Entry
Credits
Props @username, @username2, ...Checklist: