Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: test against multiple snapshot variations #342

Merged
merged 32 commits into from
Apr 9, 2019
Merged

Feature: test against multiple snapshot variations #342

merged 32 commits into from
Apr 9, 2019

Conversation

adamsilverstein
Copy link

Note: requires 10up/wpacceptance#4

Tests against:

  • WordPress 4.9.9
  • WordPress 4.9.9 plus Gutenberg 4.9
  • WordPress 5.1.0
  • WordPress 5.1.0 plus Gutenberg 5.2.0

@adamsilverstein adamsilverstein mentioned this pull request Mar 18, 2019
Merged
@jeffpaul jeffpaul added this to the 1.5.0 milestone Mar 19, 2019
@adamsilverstein adamsilverstein force-pushed the feature/test-against-multiple-snapshots branch from 40278a4 to 714a9a5 Compare April 2, 2019 20:19
@adamsilverstein
Copy link
Author

Tests are passing in GB/non GB now, for some reason the tests only run on the first machine, the others fail to load and throw an error: https://travis-ci.org/10up/distributor/builds/514895215

image

I experience the same testing locally - only the first snapshot in the array runs the tests correctly. @tlovett1 could you please take a look at this when you have a moment to see if you can figure out why the snapshots array fails after the first snapshot?

@adamsilverstein
Copy link
Author

Error logs from after first snapshot: https://gist.github.com/adamsilverstein/79f8feb6994f974c60585494f94759c9

@tlovett1
Copy link
Member

tlovett1 commented Apr 4, 2019

@adamsilverstein just pushed something to the WPA master branch. Can you test?

@adamsilverstein adamsilverstein changed the title [WIP] Feature: test against multiple snapshot variations Feature: test against multiple snapshot variations Apr 8, 2019
@adamsilverstein adamsilverstein added type:enhancement New feature or request. and removed WIP labels Apr 8, 2019
@adamsilverstein
Copy link
Author

@tlovett1 Woohoo! that did it, I see Travis running the tests against each machine now. Once these pass I can merge and then start adding some Gutenberg specific tests.

@adamsilverstein adamsilverstein force-pushed the feature/test-against-multiple-snapshots branch from 5e4b865 to fdbb1dc Compare April 9, 2019 02:05
@adamsilverstein
Copy link
Author

Tests are green against all snapshots!

@adamsilverstein adamsilverstein force-pushed the feature/test-against-multiple-snapshots branch from f03a13e to fdbb1dc Compare April 9, 2019 17:12
@adamsilverstein
Copy link
Author

Block tests aren't passing yet, I'll work on those in a follow up PR.

Adam Silverstein added 7 commits April 9, 2019 11:21
@adamsilverstein adamsilverstein merged commit 88fe72d into develop Apr 9, 2019
@helen helen deleted the feature/test-against-multiple-snapshots branch July 18, 2019 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@adamsilverstein adamsilverstein

Labels
type:enhancement New feature or request.
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@adamsilverstein @tlovett1 @jeffpaul