Fix and simplify is_using_gutenberg()
#426
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
has_blocks()
does aget_post()
if you don't pass a string, which doesn't work for external posts (which presumably is what you're pulling). Better to pass a string.Also simplifies the rest of the function down to just reproducing the check from
has_blocks()
if you're not in WP 5.0+.Alternate Designs
Considered leaving the rest of the function alone but thought it best to just do it all at once.
Benefits
Far simplified codebase, no more fatal error, no more false positives.
Possible Drawbacks
Not seeing any.
Verification Process
Testing pulling and pushing posts written using block editor, both in network and external connections.
Checklist:
Applicable Issues
Don't have a companion issue open but you can see here http://s.hyhs.me/7bfef432f30c