Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: REST API field are not getting populated correctly #519

Merged
merged 3 commits into from
Feb 19, 2020

Conversation

dinhtungdu
Copy link
Contributor

@dinhtungdu dinhtungdu commented Feb 11, 2020

Description of the Change

Populate correct value of distributor_original_site_name and distributor_original_site_url for REST API

Alternate Designs

n/a

Benefits

The API response now returns the correct value of distributor_original_site_name and distributor_original_site_url.

Possible Drawbacks

n/a

Verification Process

Check the response of v2/posts/ to see the correct value of distributor_original_site_name and distributor_original_site_url.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Closes #324

Changelog Entry

@dinhtungdu dinhtungdu requested a review from jeffpaul February 11, 2020 04:11
@dinhtungdu dinhtungdu marked this pull request as ready for review February 11, 2020 04:16
@dinhtungdu dinhtungdu self-assigned this Feb 11, 2020
@jeffpaul jeffpaul added this to the 2.0.0 milestone Feb 11, 2020
@jeffpaul jeffpaul added the type:bug Something isn't working. label Feb 11, 2020
@jeffpaul jeffpaul requested a review from dkotter February 11, 2020 22:01
includes/rest-api.php Outdated Show resolved Hide resolved
includes/rest-api.php Outdated Show resolved Hide resolved
@dinhtungdu
Copy link
Contributor Author

@dkotter nice catches, I updated my PR, thank you!

@dinhtungdu dinhtungdu requested a review from dkotter February 14, 2020 16:49
@dkotter
Copy link
Collaborator

dkotter commented Feb 14, 2020

@dinhtungdu Looks good, thanks!

@jeffpaul jeffpaul merged commit 9dbdc83 into develop Feb 19, 2020
@jeffpaul jeffpaul deleted the fix/324-wrong-rest-api-fields branch June 30, 2020 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The distributor REST API field are not getting populated correctly
3 participants