Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syntax issue on paragraph 75 #525

Merged
merged 2 commits into from
Feb 19, 2020
Merged

Syntax issue on paragraph 75 #525

merged 2 commits into from
Feb 19, 2020

Conversation

kant
Copy link
Contributor

@kant kant commented Feb 18, 2020

Description of the Change

  • paragraph 75: Externatal --) External
  • minor formatting proposals on paragraphs 43 & 64

Alternate Designs

There is no previous PR related with this proposal

Benefits

Better documentation and cleanliness of message

Possible Drawbacks

There is no drawbacks, nor collateral damage, no break on code

Verification Process

All the proposals were done in markdown format, so there is no drawback nor incompatibilities as possible.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

There is no related or previous PR

Changelog Entry

@kant
Syntax issue on paragraph 75
d279c24 
* paragraph 75: `Externatal` --) `External`
* minor formatting proposals on paragraphs 43 & 64
@kant kant requested review from jeffpaul and jakemgold February 18, 2020 19:50
@jeffpaul jeffpaul added this to the 2.0.0 milestone Feb 19, 2020
@jeffpaul jeffpaul added the needs:documentation This requires documentation. label Feb 19, 2020
jeffpaul
jeffpaul approved these changes Feb 19, 2020
View reviewed changes
Copy link
Member

@jeffpaul jeffpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting updates and the spelling correct look good, thanks again @kant!

@jeffpaul jeffpaul merged commit c71ee55 into 10up:develop Feb 19, 2020
@kant kant deleted the patch-1 branch March 12, 2020 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffpaul jeffpaul jeffpaul approved these changes

@jakemgold jakemgold Awaiting requested review from jakemgold

Assignees

@kant kant

Labels
needs:documentation This requires documentation.
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kant @jeffpaul