Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Push UI should not disappear when push is in progress #538

Merged
merged 7 commits into from
May 21, 2020
Merged

Conversation

dinhtungdu
Copy link
Contributor

Description of the Change

  • Add a background hack to prevent accident click when push is in progress.
  • Keep UI visible when push is in progress.
  • Fix watch task to make it work with gulp 4.

Alternate Designs

n/a

Benefits

  • Better UX for pushing posts.

Possible Drawbacks

n/a

Verification Process

  1. Set up and configure distributor, add at least 1 connection.
  2. On the edit page, hover on the Distributor link of the admin bar.
  3. See: the other parts of the page covered with a black overlay.
  4. Choose a connection, click the Distribute button and quickly move the cursor outside the push UI.
  5. See: the UI is still visible.
  6. See: other parts of the edit page can't be clicked.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Closes #275

Changelog Entry

@dinhtungdu dinhtungdu marked this pull request as ready for review March 9, 2020 13:02
@dinhtungdu dinhtungdu self-assigned this Mar 9, 2020
@jeffpaul jeffpaul added the type:enhancement New feature or request. label Mar 9, 2020
@jeffpaul jeffpaul added this to the 2.0.0 milestone Mar 9, 2020
@dkotter dkotter self-requested a review April 9, 2020 20:31
assets/js/push.js Outdated Show resolved Hide resolved
@dkotter
Copy link
Collaborator

dkotter commented Apr 9, 2020

While testing this, found one minor bug I left a comment about.

Overall I think this is better then what we have but I ran into on issue.

If I click to distribute something and then immediately move my cursor out of the dropdown, it stays open during and after the distribution, which is nice. But if I then move my cursor back to the overlay, it immediately closes, which is a little jarring.

@dinhtungdu dinhtungdu requested a review from dkotter April 9, 2020 23:53
@dinhtungdu
Copy link
Contributor Author

Thank you @dkotter, I addressed all issues you mentioned, please take another look to this : )

assets/js/push.js Outdated Show resolved Hide resolved
@dinhtungdu dinhtungdu requested a review from dkotter April 12, 2020 22:59
@dkotter dkotter merged commit d1ad778 into develop May 21, 2020
@dkotter dkotter deleted the fix/275 branch May 21, 2020 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Push UI should not disappear when push is in progress
3 participants