Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to building hookdocs on commits to master #545

Merged
merged 2 commits into from
Mar 18, 2020
Merged

Conversation

jeffpaul
Copy link
Member

Description of the Change

This PR updates our hookdoc generation to ONLY occur on a push to master instead of on a push to develop.

Alternate Designs

n/a

Benefits

Ensures our hookdocs only shows hook details that are available in a released version of Distributor.

Possible Drawbacks

No view on in-progress changes to hooks, only a post-release view.

Verification Process

Manually verified via the GitHub web UI.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

n/a

Changelog Entry

n/a

@jeffpaul jeffpaul added the needs:documentation This requires documentation. label Mar 12, 2020
@jeffpaul jeffpaul added this to the 2.0.0 milestone Mar 12, 2020
@jeffpaul jeffpaul requested a review from helen March 12, 2020 02:59
@jeffpaul jeffpaul self-assigned this Mar 12, 2020
@jeffpaul jeffpaul merged commit adaa2a9 into develop Mar 18, 2020
@jeffpaul jeffpaul deleted the update/hookdocs branch June 30, 2020 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:documentation This requires documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants