Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show 'View' link in push UI for external connections #571

Merged
merged 2 commits into from
Apr 10, 2020
Merged

Show 'View' link in push UI for external connections #571

merged 2 commits into from
Apr 10, 2020

Conversation

dinhtungdu
Copy link
Contributor

Description of the Change

Show 'View' link that links to distributed post URL of external connections. Fixes #115.

Alternate Designs

n/a

Benefits

Consistent UX for internal and external connections.

Possible Drawbacks

n/a

Verification Process

Note that #570 need to be merged before testing this PR.

  1. Setup an external connection.
  2. Push a post to the external connection created above.
  3. See the View link appears after pushing successfully.
  4. Refresh the edit page.
  5. Open the Push UI.
  6. See the View link in the distributed external connection row.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

#115

Changelog Entry

@dinhtungdu dinhtungdu self-assigned this Mar 27, 2020
@dinhtungdu dinhtungdu added the type:enhancement New feature or request. label Mar 27, 2020
@jeffpaul jeffpaul added this to the 2.0.0 milestone Mar 27, 2020
@jeffpaul jeffpaul requested a review from dkotter March 27, 2020 13:55
@dkotter
Copy link
Collaborator

dkotter commented Apr 3, 2020

Testing this out, with the changes from #570 as well, and this works great!

@dkotter dkotter merged commit 919db4f into develop Apr 10, 2020
@dkotter dkotter deleted the fix/115 branch April 10, 2020 16:06
@dkotter dkotter mentioned this pull request Jun 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkotter dkotter dkotter approved these changes

Assignees

@dinhtungdu dinhtungdu

Labels
type:enhancement New feature or request.
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

Show View link in Push menu for external connections
3 participants
@dinhtungdu @dkotter @jeffpaul