Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Auth Wizard not properly handling enter key actions #594

Merged
merged 7 commits into from
Jun 15, 2020

Conversation

dinhtungdu
Copy link
Contributor

@dinhtungdu dinhtungdu commented Jun 12, 2020

Description of the Change

This PR fixes/implements the following behavior:

  • Trigger click event of Authorize Connection button when press enter key on External connection site URL field.
  • When editing an external connection, the submit action is updating the action, not starting the auth process.
  • For .com apps, the enter key needs to submit the client ID/secret and start that auth process.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

@dinhtungdu dinhtungdu self-assigned this Jun 12, 2020
@dinhtungdu dinhtungdu requested a review from helen June 12, 2020 02:06
@jeffpaul jeffpaul added this to the 1.6.0 milestone Jun 12, 2020
@helen
Copy link
Contributor

helen commented Jun 12, 2020

Can we use this PR to address all the enter key usage on the connection setup/edit screen? I notice the following:

  • When editing an external connection, the submit action is updating the action, not starting the auth process.
  • For .com apps, the enter key needs to submit the client ID/secret and start that auth process.

@helen
Copy link
Contributor

helen commented Jun 12, 2020

Also noting that the corresponding issue this should fix is #584

@dinhtungdu dinhtungdu changed the title [Auth Wizard] Support pressing Enter on site URL to authorize connection Fix: Auth Wizard not properly handling enter key actions Jun 12, 2020
@dinhtungdu
Copy link
Contributor Author

@helen This PR is ready to review again.

Copy link
Contributor

@helen helen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected!

@helen helen merged commit ddba355 into develop Jun 15, 2020
@dinhtungdu dinhtungdu deleted the fix/ext-site-url-enter-key branch July 2, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auth Wizard not properly handling enter key actions
3 participants