Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: enable multisite support for VIP Go sites #606

Merged
merged 2 commits into from
Jul 2, 2020
Merged

Fix: enable multisite support for VIP Go sites #606

merged 2 commits into from
Jul 2, 2020

Conversation

dinhtungdu
Copy link
Contributor

Description of the Change

Since all sites on VIP have been migrated to VIP Go, we can safely remove the logic that disables network connection on (old) VIP sites.

Alternate Designs

N/A.

Benefits

Support internal connections for VIP Go sites.

Possible Drawbacks

N/A.

Verification Process

Manual verification.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Fixes #500.

Changelog Entry

@dinhtungdu dinhtungdu self-assigned this Jul 2, 2020
@jeffpaul jeffpaul added this to the 1.6.0 milestone Jul 2, 2020
@jeffpaul jeffpaul requested a review from helen July 2, 2020 13:21
@helen helen merged commit 985ebfe into develop Jul 2, 2020
@helen helen deleted the fix/500 branch July 2, 2020 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VIP Go setup
3 participants