Fix: empty admin body class breaks other plugins' styling #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkotter
previously approved these changes
Nov 3, 2020
|
@dinhtungdu looks like test failures on WP 5.1, can you check on those? |
|
@dinhtungdu looks like issue(s) on unit tests/linting, can you please check those? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR fixes the bug discovered in #287 where Distributor breaks other plugins' admin styling.
Alternate Designs
None.
Benefits
Keep other plugins working when distributor is activated.
Possible Drawbacks
None that I'm aware of.
Verification Process
See #287
Checklist:
Applicable Issues
Fixes #287
Changelog Entry