Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/screenshots #673

Merged
merged 5 commits into from
Dec 11, 2020
Merged

Update/screenshots #673

merged 5 commits into from
Dec 11, 2020

Conversation

jeffpaul
Copy link
Member

@jeffpaul jeffpaul commented Dec 7, 2020

Description of the Change

This PR moves the screenshot files out of the assets directory into the .github directory and updates the links accordingly in the README.md file.

Alternate Designs

Keep as-is, but that means the ZIP file is unnecessarily larger than necessary.

Benefits

Ensures the distributed plugin is as lean as possible.

Possible Drawbacks

none identified

Verification Process

Tested locally via GitHub Desktop.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Closes #669.

Changelog Entry

Docs updates

@jeffpaul jeffpaul self-assigned this Dec 7, 2020
@jeffpaul jeffpaul requested a review from dinhtungdu December 7, 2020 04:45
@jeffpaul jeffpaul added this to the 1.6.2 milestone Dec 7, 2020
@jeffpaul jeffpaul added the needs:documentation This requires documentation. label Dec 7, 2020
@jeffpaul jeffpaul merged commit ee1f1cb into develop Dec 11, 2020
@jeffpaul jeffpaul deleted the update/screenshots branch December 11, 2020 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:documentation This requires documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move readme screenshots out of assets directory
1 participant