-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Add guide for enabling Application Passwords on 5.6 #682
Conversation
Code looks fine here. Tested on both WP 5.5 and 5.6 and on 5.5, everything worked great. I did run into one issue on 5.6 though. If you try and use the wizard to create a connection to another site that isn't on 5.6 yet, you'll end up getting sent to a 404 page (because the Not sure if this is something we want to try and fix here, checking what WordPress version the external site is running and using the |
@dkotter Nice catch! I missed that important point. The Application Password endpoint should be based on the remote site, not the origin site. I pushed a solution to fix that. There is still a case that hasn't been covered: the remote site is updated to WP 5.6 but Distributor isn't. We can't get the WP version or the core Application Passwords status through REST API. A dev note in the readme is the only thing we can do IMO. |
@dinhtungdu does that minor docs change help call out what we're requiring or should we be more verbose/explicit? |
Just wanted to mention that you can check whether the target site supports app passwords by making a request to the REST API Index ( |
@dkotter is there perhaps an update we should make in how Distributor is leveraging App Pwds based on @TimothyBJacobs note above? |
Yeah, that seems like a better approach. Probably worth opening an issue to get things updated to follow best practices |
Description of the Change
This PR adds a new section for Application Passwords and 5.6 debug guide. This also updates the auth page URL to make the Auth Wizard work on 5.6.
Verification Process
Checklist:
Applicable Issues
Changelog Entry