-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hiding registration notice when it's registered #702
Hiding registration notice when it's registered #702
Conversation
Thanks for this @dhanendran. Left a minor comment but otherwise this looks good! |
@dkotter I have addressed the spacing issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dhanendran, thank you for the PR. This PR is hiding the notice when the plugin is first time activated, where the valid_license
is null
, not false
. Otherwise, this is ready to go.
@dinhtungdu Thanks for your suggestion. I have made the changes now. |
Description of the Change
Fixes #501. This change hides the registration notice when the valid registration key is added.
Alternate Designs
N/A
Benefits
This change will help to avoid the confusion of seeing the registration notice even after adding the valid key.
Possible Drawbacks
N/A
Verification Process
Checklist:
Applicable Issues
#501
Changelog Entry