Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiding registration notice when it's registered #702

Merged
merged 3 commits into from
Jan 27, 2021

Conversation

dhanendran
Copy link
Member

Description of the Change

Fixes #501. This change hides the registration notice when the valid registration key is added.

Alternate Designs

N/A

Benefits

This change will help to avoid the confusion of seeing the registration notice even after adding the valid key.

Possible Drawbacks

N/A

Verification Process

  • Message should be shown when the fields are empty
  • Message should be shown when invalid licence key is added
  • Message should be hidden when there is a valid licence key

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

#501

Changelog Entry

includes/settings.php Outdated Show resolved Hide resolved
includes/settings.php Outdated Show resolved Hide resolved
@dkotter
Copy link
Collaborator

dkotter commented Jan 22, 2021

Thanks for this @dhanendran. Left a minor comment but otherwise this looks good!

@dhanendran
Copy link
Member Author

@dkotter I have addressed the spacing issue.

Copy link
Contributor

@dinhtungdu dinhtungdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dhanendran, thank you for the PR. This PR is hiding the notice when the plugin is first time activated, where the valid_license is null, not false. Otherwise, this is ready to go.

includes/settings.php Outdated Show resolved Hide resolved
includes/settings.php Outdated Show resolved Hide resolved
@dhanendran
Copy link
Member Author

@dinhtungdu Thanks for your suggestion. I have made the changes now.

@jeffpaul jeffpaul requested a review from dkotter January 25, 2021 19:30
@jeffpaul jeffpaul added this to the 1.6.3 milestone Jan 25, 2021
@jeffpaul jeffpaul merged commit f517788 into 10up:develop Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "Registration" notice when registered
4 participants