Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test for _wp_attachment_metadata blacklist #706

Merged
merged 2 commits into from
Feb 2, 2021
Merged

test for _wp_attachment_metadata blacklist #706

merged 2 commits into from
Feb 2, 2021

Conversation

dhanendran
Copy link
Member

Description of the Change

PHPUnit test for #289
Issue: #306

Benefits

Ensures _wp_attachment_metadata is not distributed to other sites.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

#306

Changelog Entry

@dhanendran dhanendran mentioned this pull request Jan 25, 2021
Closed
@jeffpaul jeffpaul added this to the 1.6.3 milestone Jan 27, 2021
@jeffpaul jeffpaul requested a review from dinhtungdu January 27, 2021 22:46
dinhtungdu
dinhtungdu approved these changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@dinhtungdu dinhtungdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me!

@jeffpaul jeffpaul linked an issue Feb 2, 2021 that may be closed by this pull request
Tests: Ensure meta blacklist is applied to attachments #306
Closed
@jeffpaul jeffpaul merged commit 77d0071 into 10up:develop Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinhtungdu dinhtungdu dinhtungdu approved these changes

Assignees

@dhanendran dhanendran

Labels
None yet
Projects
None yet
Milestone
1.6.3
Development

Successfully merging this pull request may close these issues.

Tests: Ensure meta blacklist is applied to attachments
3 participants
@dhanendran @dinhtungdu @jeffpaul