Add ability to Unskip or Pull items from the Skipped tab on the Pull screen #728
Conversation
…ems. Add necessary processing to properly unskip an item. Add helper functions to get a sync log from a connection. Add ability to overwrite the entire sync log for a connection
| * @since 0.8 | ||
| */ | ||
| public function log_sync( array $item_id_mappings, $blog_id = 0 ) { | ||
| public function log_sync( array $item_id_mappings, $blog_id = 0, $overwrite = false ) { |
There was a problem hiding this comment.
@jeffpaul I think the logic for $overwrite is missing from this function. Currently the post ID is set to false which means it still shows on the skipped screen.
If an empty array is passed to $item_id_mappings it will fallback to $current_site_log instead, but it should overwrite.
There was a problem hiding this comment.
@elliott-stocks Ah, nice catch. I had refactored this a bit and in the process I ended up breaking things. I believe it should be working properly now
|
|
||
| $connection->log_sync( $sync_log, intval( $_GET['connection_id'] ), true ); | ||
|
|
||
| setcookie( 'dt-unskipped', 1, time() + DAY_IN_SECONDS, ADMIN_COOKIE_PATH, COOKIE_DOMAIN, is_ssl() ); |
There was a problem hiding this comment.
@dkotter VIP will flag this due to caching, although as it's in the admin it may not be an issue. Testing locally on VIP seems fine, but it may fail PHPCS.
There was a problem hiding this comment.
Yeah, I debated changing how this works but this is how we already handle skipped or pulled items, by setting a cookie. So I decided it was best to just follow the pattern we already have in place.
Description of the Change
At the moment, if you Skip an item from the Pull screen, that item goes to a Skipped tab. From here, the only option a user has is to view that item. So if someone were to accidentally Skip an item or change their mind later, there isn't an easy way for them to later pull that item.
This PR adds the same Pull options to the Skipped tab, both in the bulk actions and in the inline row options. This allows someone to directly Pull an item from the Skipped tab.
In addition, it adds a new Unskip option, both in the bulk actions and in an inline row option. If this Unskip option is used, the Skipped item is sent back to the New screen and can then be Pulled from there later (or Skipped again if desired).
Note: by default, we show the 10 most recent items on the new screen. If someone were to Unskip an item that doesn't belong to one of those 10 items, this item will still be Unskipped but won't show up on the first page of results. Pagination will have to be used to find this item.
Alternate Designs
None
Benefits
Users can now Unskip or directly Pull previously Skipped items
Possible Drawbacks
None
Verification Process
Checklist:
Applicable Issues
Addresses part of #392