Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add banner and icon assets #736

Merged
merged 1 commit into from
Mar 23, 2021
Merged

add banner and icon assets #736

merged 1 commit into from
Mar 23, 2021

Conversation

jeffpaul
Copy link
Member

Description of the Change

This PR adds icon and banner assets for display in the plugin update process as well as when someone views plugin details in the admin.

Alternate Designs

Keep as-is without icon and banner asset display within WP Admin.

Benefits

Ensures we appropriately display Distributor branding when available and expected within the WP Admin.

Possible Drawbacks

Additional plugin weight.

Verification Process

Manually verified via GitHub Desktop UI.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

n/a

Changelog Entry

### Added
- Plugin banner and icon assets (props @JackieKjome).

@jeffpaul jeffpaul added this to the 1.7.0 milestone Mar 11, 2021
@jeffpaul jeffpaul self-assigned this Mar 11, 2021
@jeffpaul jeffpaul added the type:enhancement New feature or request. label Mar 11, 2021
@jeffpaul jeffpaul modified the milestones: 1.7.0, 1.6.4 Mar 22, 2021
Copy link
Contributor

@helen helen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, kind of funny the bigger banner is smaller in filesize but it's a tiny file and an even smaller difference.

@jeffpaul jeffpaul merged commit 1f7838b into develop Mar 23, 2021
@jeffpaul jeffpaul deleted the add/assets branch March 23, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants