Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filters to control terms and meta distribution for internal connections #800

Merged
merged 2 commits into from
Sep 24, 2021

Conversation

dinhtungdu
Copy link
Contributor

This PR adds two new filters that allow themes/plugins to control the term and meta distribution for internal connections.

@jeffpaul jeffpaul added this to the 1.6.6 milestone Sep 23, 2021
@jeffpaul jeffpaul requested a review from dkotter September 23, 2021 17:03
dkotter
dkotter previously approved these changes Sep 23, 2021
@dkotter
Copy link
Collaborator

dkotter commented Sep 23, 2021

This looks good to me but just wanted to ask a couple questions:

  1. This adds new filters to turn off the distribution of terms and/or meta when pushing content from an internal connection. Should we also add similar filters when pulling? I see we have already both dt_push_post_media and dt_pull_post_media, wondering if these two new filters should also have corresponding pull versions?
  2. If we add pull versions, should we look to add these same filters when pulling content from external connections? We do already have the same dt_pull_post_media filter on external connections. I think it becomes more difficult to add the same filters when pushing from an external connection, just based on how that is handled, but could probably add those when pushing

@dinhtungdu
Copy link
Contributor Author

@dkotter Thanks so much for the head-up. I added pull versions of those filters, please take another look!

@dkotter
Copy link
Collaborator

dkotter commented Sep 24, 2021

Looks good!

@jeffpaul jeffpaul merged commit 2e80474 into develop Sep 24, 2021
@jeffpaul jeffpaul deleted the add/internal-connection-content-filters branch September 24, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants