Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/862 Search form moved outside of the filter form #878

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Conversation

faisal-alvi
Copy link
Member

@faisal-alvi faisal-alvi commented Apr 27, 2022

Description of the Change

  • This PR moves the search form outside of the filter form.
  • Earlier hitting the enter key while the cursor is on the page number input field, the search form was being submitted instead of the filter form.

Closes #862

Verification Process

  1. Go to the Pull Content screen.
  2. Ensure you're on a connection that has multiple pages of results. If not, create at least 2 posts/pages and set Posts per page to 2 in the Screen Options.
  3. Manually enter any page other than 1.
  4. Hit enter and see the requested page is loaded.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Fixed - Manually entering a page number doesn't work on the Pull screen

Credits

Props @faisal-alvi @dkotter

@faisal-alvi faisal-alvi added this to the 1.7.0 milestone Apr 27, 2022
@faisal-alvi faisal-alvi requested a review from dkotter April 27, 2022 13:01
@faisal-alvi faisal-alvi self-assigned this Apr 27, 2022
@dkotter
Copy link
Collaborator

dkotter commented Apr 29, 2022

Looks good, thanks! Tested both Internal and External connections, both with the default post post type and custom post types and all pagination functionality works as expected now.

@dkotter dkotter merged commit 6d20a4c into develop Apr 29, 2022
@dkotter dkotter deleted the fix/862 branch April 29, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manually entering a page number doesn't work on Pull screen
2 participants