Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change GH Action used for deploy to GH Pages #886

Merged
merged 1 commit into from
May 27, 2022
Merged

Conversation

iamdharmesh
Copy link
Member

Description of the Change

Following the failure in deploy to GH Pages in Classifai and ElasticPress, this PR has been raised to replace the broken GH action used for deploy to GH Pages.

This PR changes the GH Action used to publish to the GH Pages. Previously, we were using https://github.com/maxheld83/ghpages, and this PR changes to use https://github.com/peaceiris/actions-gh-pages

ClassifAI PR: 10up/classifai#345
ElasticPress PR: 10up/ElasticPress#2803

Alternate Designs

Maybe debug an issue in the existing action and fix it or choose any other GH action to deploy to GH pages.

Possible Drawbacks

Verification Process

Hook Docs should deploy correctly once this is merged to the trunk. We will need to merge this one to the trunk to see if it works.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Changed: GH Action used for deploy to GH Pages

Credits

Props @iamdharmesh

@iamdharmesh iamdharmesh self-assigned this May 27, 2022
@iamdharmesh iamdharmesh requested review from a team and dkotter and removed request for a team May 27, 2022 11:57
@iamdharmesh iamdharmesh added this to the 1.7.0 milestone May 27, 2022
@jeffpaul jeffpaul merged commit 20b7d76 into develop May 27, 2022
@jeffpaul jeffpaul deleted the fix/gh-pages-deploy branch May 27, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants