Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Known Issue of Full Screen mode #897

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Conversation

faisal-alvi
Copy link
Member

Description of the Change

As we have already fixed the full-screen issue (in #750) mentioned in the readme file. We should remove it.

__Gutenberg Fullscreen Mode__ - [Gutenberg 3.8](https://wptavern.com/gutenberg-3-8-released-adds-full-screen-mode) originally introduced `Fullscreen mode` for the editor and [WordPress 5.4](https://make.wordpress.org/core/2020/03/03/fullscreen-mode-enabled-by-default-in-the-editor/) and [Gutenberg 7.7](https://github.com/WordPress/gutenberg/pull/20611) made that the default setting. Fullscreen mode creates a problem as the admin bar is no longer visible which means the Distributor push menu is no longer visible. We are [working on researching a resolution to this issue](https://github.com/10up/distributor/issues/597), but in the meantime we recommend clicking on the three vertical dots in the upper right corner of Gutenberg and disabling fullscreen mode to ensure the admin bar and Distributor push menu is in view.

Alternate Designs

n/a

Possible Drawbacks

n/a

@faisal-alvi faisal-alvi requested a review from dkotter June 21, 2022 10:25
@faisal-alvi faisal-alvi self-assigned this Jun 21, 2022
@dkotter dkotter merged commit 25c9c66 into develop Jun 21, 2022
@dkotter dkotter deleted the remove-full-screen-issue branch June 21, 2022 21:31
@jeffpaul
Copy link
Member

Great catch on this @faisal-alvi, thank you!

@jeffpaul jeffpaul added this to the 1.7.0 milestone Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants