Add E2E tests for Minumum Plugin Requirements #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterwilsoncc
force-pushed
the
add/440-e2e-min-requirements
branch
from
39d14e4 to
8983ebf
Compare
peterwilsoncc
force-pushed
the
add/440-e2e-min-requirements
branch
from
6cfdfbf to
f63e3e3
Compare
peterwilsoncc
force-pushed
the
add/440-e2e-min-requirements
branch
from
f63e3e3 to
6c22785
Compare
peterwilsoncc
force-pushed
the
add/440-e2e-min-requirements
branch
from
8655475 to
ca87104
Compare
peterwilsoncc
requested review from
a team,
dinhtungdu and
faisal-alvi
and removed request for
a team and
dinhtungdu
faisal-alvi
approved these changes
Sep 2, 2022
There was a problem hiding this comment.
@peterwilsoncc this is so clean! thanks for the PR. ❤️
Re-ran the workflow and confirmed tests are working fine + passing.
12 tasks
peterwilsoncc
added a commit
that referenced
this pull request
Dec 13, 2022
Add E2E tests for Minumum Plugin Requirements # Conflicts: # .github/workflows/cypress.yml # tests/bin/set-core-version.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Adds the PHP version to the E2E test matrix:
tests/bin/set-core-version.jsso the override file is always written now there are multiple argumentsCloses #440
How to test the Change
Review E2E tests section of GitHub actions for this pull request.
Changelog Entry
Credits
Props @peterwilsoncc, @jeffpaul, @faisal-alvi
Checklist: