Fix undefined variable localizing gutenberg-syndicated-post.
#945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterwilsoncc
requested review from
a team and
cadic
and removed request for
a team
Sidsector9
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Fixes a bug introduced during requirement bump causing an undefined variable notice while enqueuing
gutenberg-syndicated-post.js.During the switch to wp-scripts, the use of the variable was replaced with the
wp.i18npackage so can be removedSee #905.
Follow up to 7be0237 in #917.
How to test the Change
Changelog Entry
Credits
Props @peterwilsoncc, @Sidsector9
Checklist: