Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent distribution of classic-editor-remember post meta. #977

Merged
merged 2 commits into from
Dec 1, 2022

Conversation

peterwilsoncc
Copy link
Collaborator

@peterwilsoncc peterwilsoncc commented Nov 22, 2022

Description of the Change

Prevents the distribution of the classic-editor-remember post meta data from one site to another.

This setting is used to determine whether a post should be opened in the block or classic editor on sites with the classic editor plugin installed.

On sites with the plugin installed, the preference should be made by that sites editors. On sites without the plugin installed then the meta data is not needed and fills their post meta table with junk.

Closes #976

How to test the Change

  1. Install the classic editor on two Distributor enabled site
  2. Set it to allow users to switch between the editor of their choice (Settings > Writing)
  3. Author and publish a post in the block editor
  4. Open the post in the classic editor
  5. Close without saving.
  6. Either push or pull the post to another site
  7. Edit the Distributed post on the second site
  8. Ensure the post still opens in the block editor

Changelog Entry

Fixed - Prevent distribution of classic editor plugin related meta data.

Credits

Props @peterwilsoncc, @faisal-alvi, @jeffpaul

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@peterwilsoncc peterwilsoncc marked this pull request as ready for review November 22, 2022 04:36
@peterwilsoncc peterwilsoncc requested review from a team and faisal-alvi and removed request for a team November 22, 2022 04:38
Copy link
Member

@faisal-alvi faisal-alvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterwilsoncc thanks for the work. I've followed the mentioned steps and the distributed post opened in the block editor. Admin/Editor is also able to switch between the editors.

@jeffpaul jeffpaul added this to the 2.0.0 milestone Dec 1, 2022
@peterwilsoncc peterwilsoncc merged commit 4fa141d into develop Dec 1, 2022
@peterwilsoncc peterwilsoncc deleted the fix/976-remember-classic-independently branch December 1, 2022 23:24
@peterwilsoncc peterwilsoncc modified the milestones: 2.0.0, 1.9.0 Dec 13, 2022
peterwilsoncc added a commit that referenced this pull request Dec 13, 2022
Prevent distribution of `classic-editor-remember` post meta.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

classic-editor-remember post meta is distributed.
3 participants