upkeep/wp-deploy: Move from actions/upload-release-asset to softprops/action-gh-release
#262
Conversation
|
@Sidsector9 thanks for the PR! Could you please fill out the PR template with description, changelog, and credits information so that we can properly review and merge this? |
github-actions
bot
added
the
needs:feedback
| @@ -21,11 +21,8 @@ jobs: | |||
| SVN_PASSWORD: ${{ secrets.SVN_PASSWORD }} | |||
| SVN_USERNAME: ${{ secrets.SVN_USERNAME }} | |||
| - name: Upload release asset | |||
| uses: actions/upload-release-asset@v1 | |||
| uses: softprops/action-gh-release@v2 | |||
There was a problem hiding this comment.
Realizing I just approved/merged in some other repos, but curious if we need to similarly update other actions?
There was a problem hiding this comment.
@jeffpaul we don't need to update the actions you mentioned as this change is only for the asset we attach to the release. The plugin build zip and asset deploy actions are unrelated.
Though we need to update the examples here:
There was a problem hiding this comment.
@Sidsector9 mind pushing a fix for the action examples then?
There was a problem hiding this comment.
Opened a PR here - 10up/action-wordpress-plugin-deploy#150
Description of the Change
actions/upload-release-assethas been deprecated andsoftprops/action-gh-releaseis the recommended replacement.How to test the Change
Verify the ZIP attached in a release.
Changelog Entry